Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite hbs plugin should return resolutions #2143

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Vite hbs plugin should return resolutions #2143

merged 2 commits into from
Oct 9, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Oct 8, 2024

The lack of the return is probably doubling the amount of resoultion work in downstream plugins.

Also the extra fallback here should not be needed anymore given that the default resolve is supposed to check for hbs.

The lack of the return is probably doubling the amount of resoultion work in downstream plugins.

Also the extra fallback here should not be needed anymore given that the default resolve is supposed to check for hbs.
@ef4 ef4 added the bug Something isn't working label Oct 8, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@ef4 ef4 merged commit 5b4f982 into main Oct 9, 2024
154 checks passed
@ef4 ef4 deleted the vite-hbs-cleanup branch October 9, 2024 13:38
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants